Skip to content
Snippets Groups Projects
Select Git revision
0 results
Search by author
  • Any Author
0 authors
  1. Oct 30, 2014
  3. Jul 16, 2014
    • Nahum Shalman's avatar
      fix nfs4-acl-editor compilation on Fedora · b27bfc83
      Nahum Shalman authored 
      
strlcpy -> strncpy

Signed-off-by: default avatarJ. Bruce Fields <bfields@redhat.com>
      b27bfc83
    • Daniel Kobras's avatar
      nfs4_setfacl.c: Fix fd leak in edit_ACL() · ba94f4b4
      Daniel Kobras authored 
      
nfs4_editfacl (aka. nfs4_setfacl -e) creates temporary files for ACL
editing, but doesn't close the associated file descriptors at runtime.
Therefore, the amount of files that can be adjusted with a single
invocation of nfs4_editfacl (nfs4_setfacl -e) is limited by the
process's RLIMIT_NOFILE setting.

This becomes a problem when you try to -R/--recursive on a tree with
more than RLIMIT_NOFILE objects; for example:

	$ mkdir TMP; cd TMP
	$ for i in $(seq 1 100); do mkdir $i; done
	$ ulimit -n 99
	$ EDITOR=/bin/true nfs4_editfacl -R -P .
	Unable to make tempfile "/tmp/.nfs4_setfacl-tmp-R2jd85" for editing.
	An error occurred during recursive file tree walk.

Signed-off-by: default avatarJ. Bruce Fields <bfields@redhat.com>
      ba94f4b4
  5. Feb 19, 2014
  7. May 21, 2013
  9. May 13, 2013
  11. Jul 18, 2012
    • Liam Gretton's avatar
      allow spaces in principal names · ae091661
      Liam Gretton authored 
      
Change the behaviour of nfs4_setfacl slightly to allow it to add, remove
and modify ACLs which act on principals containing space characters.

The rationale behind this is to allow us to use nfs4_setfacl on a file
system which is shared via CIFS to Windows clients and NFSv4. Though
very rare in a Unix environment, Windows commonly uses user names (and
hence principals derived from them) which contain spaces. A
particularly common one is 'Domain Admins', the handling of which
prompted me to look at modifying the nfs4_setfacl command.

As of 0.3.3 of nfs4-acl-tools, nfs4_setfacl fails to handle ACLs
containing a space character no matter what attempts to quote the ACE
or escape the space character:

Scanning ACE string 'A:fdg:Domain' failed.
Failed while inserting ACE(s) (at index 1).

(exit status 1.)

Scanning ACE string 'A:fdg:Domain' failed.
Failed while inserting ACE(s) (at index 1).

(exit status 1.)

The attached patch modifies the parsing of the command line and
disallows space as an ACE delimiter. The patched version completes
successfully:

A:fdg:Domain Admins@le.ac.uk:rtncy

ACEs can be chained with commas, but no longer with spaces. With the
-A, -X, -S or -e options which expect a file containing ACLs, ACEs can
be separated with tabs, newlines and/or carriage returns as before.

As there's a slight change in behaviour, the patch also modifies one of
the examples given in the EXAMPLES section of nfs4_setfacl(1) and the
text of the 'ACL FORMAT' section of nfs4_acl.

The patches don't modify any version numbers or dates.

Signed-off-by: default avatarJ. Bruce Fields <bfields@redhat.com>
      ae091661
  13. Aug 16, 2011
  15. Aug 05, 2011
  17. Sep 15, 2009
    • Brian De Wolf's avatar
      allow parsing ACEs with empty masks · 75053cc0
      Brian De Wolf authored 
      
After upgrading from 0.3.2 to 0.3.3 to fix some segfaulting issues we
had, 0.3.3 now rejects ACEs that have empty mask fields.  This is
because the function parse_alloc_fields checks whether the three strings
are zero length.  Having a zero length "type" or "who" definitely
doesn't make sense, but having an empty mask is entirely possible.  It's
allowed in the old versions and the ZFS back-end in our setup allows
them too.  Even nfs4_getfacl prints them out, producing the frustrating
situation where nfs4_getfacl can produce ACLs that you can't apply with
nfs4_setfacl.

This patch modifies the function to not check if the mask is an empty
string.

Signed-off-by: default avatarJ. Bruce Fields <bfields@citi.umich.edu>
      75053cc0
  19. Dec 03, 2008
  21. Aug 22, 2008