- May 13, 2013
-
-
J. Bruce Fields authored
Thanks to Oliver Lee for the report. Signed-off-by:
J. Bruce Fields <bfields@redhat.com>
-
J. Bruce Fields authored
Thanks to Oliver Lee for the report. Signed-off-by:
J. Bruce Fields <bfields@redhat.com>
-
- Jul 18, 2012
-
-
Liam Gretton authored
Change the behaviour of nfs4_setfacl slightly to allow it to add, remove and modify ACLs which act on principals containing space characters. The rationale behind this is to allow us to use nfs4_setfacl on a file system which is shared via CIFS to Windows clients and NFSv4. Though very rare in a Unix environment, Windows commonly uses user names (and hence principals derived from them) which contain spaces. A particularly common one is 'Domain Admins', the handling of which prompted me to look at modifying the nfs4_setfacl command. As of 0.3.3 of nfs4-acl-tools, nfs4_setfacl fails to handle ACLs containing a space character no matter what attempts to quote the ACE or escape the space character: Scanning ACE string 'A:fdg:Domain' failed. Failed while inserting ACE(s) (at index 1). (exit status 1.) Scanning ACE string 'A:fdg:Domain' failed. Failed while inserting ACE(s) (at index 1). (exit status 1.) The attached patch modifies the parsing of the command line and disallows space as an ACE delimiter. The patched version completes successfully: A:fdg:Domain Admins@le.ac.uk:rtncy ACEs can be chained with commas, but no longer with spaces. With the -A, -X, -S or -e options which expect a file containing ACLs, ACEs can be separated with tabs, newlines and/or carriage returns as before. As there's a slight change in behaviour, the patch also modifies one of the examples given in the EXAMPLES section of nfs4_setfacl(1) and the text of the 'ACL FORMAT' section of nfs4_acl. The patches don't modify any version numbers or dates. Signed-off-by:
J. Bruce Fields <bfields@redhat.com>
-
- Aug 16, 2011
-
-
J. Bruce Fields authored
Signed-off-by:
J. Bruce Fields <bfields@redhat.com>
-
J. Bruce Fields authored
Another autogenerated file that shouldn't be under version control. Signed-off-by:
J. Bruce Fields <bfields@redhat.com>
-
J. Bruce Fields authored
Note that the GUI especially hasn't been getting a lot of love, and is probably useful only as a proof-of-concept for now. Signed-off-by:
J. Bruce Fields <bfields@redhat.com>
-
J. Bruce Fields authored
As suggested by Neil Brown, remove some more autogenerated files and fix the Makefile so that a make make install will suffice to generate everything necessary. Signed-off-by:
J. Bruce Fields <bfields@redhat.com>
-
- Aug 05, 2011
-
-
J. Bruce Fields authored
Signed-off-by:
J. Bruce Fields <bfields@redhat.com>
-
J. Bruce Fields authored
Signed-off-by:
J. Bruce Fields <bfields@redhat.com>
-
malahal naineni authored
Signed-off-by:
Malahal Naineni <malahal@us.ibm.com> Signed-off-by:
J. Bruce Fields <bfields@redhat.com>
-
malahal naineni authored
The sizeof operator, when applied to a parameter declared to have array, yields the size of the adjusted (pointer) type, even if the parameter declaration specifies a length. Signed-off-by:
Malahal Naineni <malahal@us.ibm.com> Signed-off-by:
J. Bruce Fields <bfields@redhat.com>
-
- Sep 15, 2009
-
-
Brian De Wolf authored
After upgrading from 0.3.2 to 0.3.3 to fix some segfaulting issues we had, 0.3.3 now rejects ACEs that have empty mask fields. This is because the function parse_alloc_fields checks whether the three strings are zero length. Having a zero length "type" or "who" definitely doesn't make sense, but having an empty mask is entirely possible. It's allowed in the old versions and the ZFS back-end in our setup allows them too. Even nfs4_getfacl prints them out, producing the frustrating situation where nfs4_getfacl can produce ACLs that you can't apply with nfs4_setfacl. This patch modifies the function to not check if the mask is an empty string. Signed-off-by:
J. Bruce Fields <bfields@citi.umich.edu>
-
- Dec 03, 2008
-
-
David M. Richter authored
Signed-off-by:
David M. Richter <richterd@citi.umich.edu>
-
David M. Richter authored
Signed-off-by:
David M. Richter <richterd@citi.umich.edu>
-
David M. Richter authored
Signed-off-by:
David M. Richter <richterd@citi.umich.edu>
-
- Aug 22, 2008
-
-
David M. Richter authored
Signed-off-by:
David M. Richter <richterd@citi.umich.edu>
-
Johann Dahm authored
Improve parse_alloc_fields()'s readability by switching from strchr() to strsep() and make sure we have the correct number of fields in the ACE. Signed-off-by:
Johann Dahm <johann.dahm@gmail.com> Signed-off-by:
David M. Richter <richterd@citi.umich.edu>
-
Johann Dahm authored
Signed-off-by:
Johann Dahm <johann.dahm@gmail.com> Signed-off-by:
David M. Richter <richterd@citi.umich.edu>
-
Johann Dahm authored
Also renames a loop variable for better readability. Signed-off-by:
Johann Dahm <johann.dahm@gmail.com> Signed-off-by:
David M. Richter <richterd@citi.umich.edu>
-
Johann Dahm authored
Signed-off-by:
Johann Dahm <johann.dahm@gmail.com> Signed-off-by:
David M. Richter <richterd@citi.umich.edu>
-
Johann Dahm authored
Signed-off-by:
Johann Dahm <johann.dahm@gmail.com> Signed-off-by:
David M. Richter <richterd@citi.umich.edu>
-
Johann Dahm authored
Signed-off-by:
Johann Dahm <johann.dahm@gmail.com> Signed-off-by:
David M. Richter <richterd@citi.umich.edu>
-
Johann Dahm authored
Signed-off-by:
Johann Dahm <johann.dahm@gmail.com> Signed-off-by:
David M. Richter <richterd@citi.umich.edu>
-
David M. Richter authored
Signed-off-by:
David M. Richter <richterd@citi.umich.edu>
-
David M. Richter authored
Properly define maximum sizes for principal names, ACE sizes, and ACL size. Previously, both the size of a given ACE and the number of ACEs allowed in an ACL were artificially constrained and caused a variety of bugs. Special thanks to Brian De Wolf for help both on and off the linux-nfs mailing list in reporting and debugging these issues. Signed-off-by:
David M. Richter <richterd@citi.umich.edu>
-
David M. Richter authored
Signed-off-by:
David M. Richter <richterd@citi.umich.edu>
-